[No QA] Fix typo #76346
[No QA] Fix typo #76346
Conversation
melvin-bot
bot
requested review from
joekaufmanexpensify
and removed request for
a team
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@jasperhuangg @brianlee-expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 91d55fdf..fdcd088d 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -4987,7 +4987,7 @@ ${
customNameWorkspaceNameExample: 'Workspace-Name: {report:workspacename}',
customNameReportIDExample: 'Report-ID: {report:id}',
customNameTotalExample: 'Gesamt: {report:total}.',
- preventMembersFromChangingCustomNamesTitle: 'Verhindern Sie, dass Mitglieder benutzerdefinierte Berichtsnamen ändern',
+ preventMembersFromChangingCustomNamesTitle: 'Verhindern, dass Mitglieder benutzerdefinierte Berichtstitel ändern',
},
reportFields: {
addField: 'Feld hinzufügen',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index de1d6428..4a8016be 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -4999,7 +4999,7 @@ ${
customNameWorkspaceNameExample: "Nom de l'espace de travail : {report:workspacename}",
customNameReportIDExample: 'Report ID : {report:id}',
customNameTotalExample: 'Total : {report:total}.',
- preventMembersFromChangingCustomNamesTitle: 'Empêcher les membres de modifier les noms des rapports personnalisés',
+ preventMembersFromChangingCustomNamesTitle: 'Empêcher les membres de modifier les titres de rapports personnalisés',
},
reportFields: {
addField: 'Ajouter un champ',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 7e026ab3..71d815b2 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -4976,7 +4976,7 @@ ${
customNameWorkspaceNameExample: "Nome dell'area di lavoro: {report:workspacename}",
customNameReportIDExample: 'Report ID: {report:id}',
customNameTotalExample: 'Totale: {report:total}.',
- preventMembersFromChangingCustomNamesTitle: 'Impedisci ai membri di modificare i nomi dei report personalizzati',
+ preventMembersFromChangingCustomNamesTitle: 'Impedisci ai membri di modificare i titoli dei report personalizzati',
},
reportFields: {
addField: 'Aggiungi campo',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index e1331418..a634b407 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -4932,7 +4932,7 @@ ${
customNameWorkspaceNameExample: 'ワークスペース名: {report:workspacename}',
customNameReportIDExample: 'Report ID: {report:id}',
customNameTotalExample: '合計: {report:total}.',
- preventMembersFromChangingCustomNamesTitle: 'メンバーがカスタムレポート名を変更するのを防ぐ',
+ preventMembersFromChangingCustomNamesTitle: 'メンバーがカスタムレポートのタイトルを変更するのを防ぐ',
},
reportFields: {
addField: 'フィールドを追加',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index f57ae877..50bc1f12 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -4967,7 +4967,7 @@ ${
customNameWorkspaceNameExample: 'Werkruimte naam: {report:workspacename}',
customNameReportIDExample: 'Report ID: {report:id}',
customNameTotalExample: 'Totaal: {report:total}.',
- preventMembersFromChangingCustomNamesTitle: 'Voorkom dat leden aangepaste rapportnamen wijzigen',
+ preventMembersFromChangingCustomNamesTitle: 'Voorkom dat leden aangepaste rapporttitels wijzigen',
},
reportFields: {
addField: 'Veld toevoegen',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 1cab38d9..d1e24d58 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -4957,7 +4957,7 @@ ${
customNameWorkspaceNameExample: 'Nazwa przestrzeni roboczej: {report:workspacename}',
customNameReportIDExample: 'Report ID: {report:id}',
customNameTotalExample: 'Suma: {report:total}.',
- preventMembersFromChangingCustomNamesTitle: 'Uniemożliw członkom zmianę nazw raportów niestandardowych',
+ preventMembersFromChangingCustomNamesTitle: 'Uniemożliw członkom zmianę niestandardowych tytułów raportów',
},
reportFields: {
addField: 'Dodaj pole',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 7d1cb608..aca82a8d 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -4960,7 +4960,7 @@ ${
customNameWorkspaceNameExample: 'Nome do espaço de trabalho: {report:workspacename}',
customNameReportIDExample: 'ID do Relatório: {report:id}',
customNameTotalExample: 'Total: {report:total}.',
- preventMembersFromChangingCustomNamesTitle: 'Impedir que os membros alterem os nomes dos relatórios personalizados',
+ preventMembersFromChangingCustomNamesTitle: 'Impedir que membros alterem os títulos personalizados de relatórios',
},
reportFields: {
addField: 'Adicionar campo',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 3bb1d2e2..082d928d 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4866,7 +4866,7 @@ ${
customNameWorkspaceNameExample: '工作区名称：{report:workspacename}',
customNameReportIDExample: '报告 ID: {report:id}',
customNameTotalExample: '总计：{report:total}。',
- preventMembersFromChangingCustomNamesTitle: '禁止成员更改自定义报告名称',
+ preventMembersFromChangingCustomNamesTitle: '禁止成员修改自定义报告标题',
},
reportFields: {
addField: '添加字段',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| 2. Click to open the formula editor. | ||
| 3. Use the formula list below to build your title. | ||
| 4. (Optional) Enable **Prevent members from changing custom report names** to lock naming rules. | ||
| 4. (Optional) Enable **Prevent members from changing custom report titles** to lock naming rules. |
There was a problem hiding this comment.
Good fix! However, there are other instances of "report names" in this document (line 29) that should also be changed to "report titles" for consistency.
HelpDot Documentation ReviewOverall AssessmentThis PR contains a minor but important terminology correction, changing "report names" to "report titles" across one documentation file and the corresponding language file. The change improves consistency and accuracy throughout the documentation by using the correct technical term that aligns with the feature name and UI elements. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a straightforward terminology correction that improves documentation accuracy and consistency. |
|
A preview of your ExpensifyHelp changes have been deployed to https://94038b75.helpdot.pages.dev ⚡️ Updated articles: |
Codecov Report✅ All modified and coverable lines are covered by tests. |
Explanation of Change
Fixes typo where
report titleswas referred to asreport namesFixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari